Actually it seems like I can't make markers at all.
Here are repro steps:
-Load Legend of Zelda (or any nes game, I've tested several) into NesHawk
-open a new tastudio window.
-Let the game play for a couple seconds.
-Try to make a marker by left clicking on a frame then right clicking and setting a marker.
It happens with Donkey Kong Country for SNES as well.
Joined: 4/17/2010
Posts: 11475
Location: Lake Chargoggagoggmanchauggagoggchaubunagungamaugg
Frame column double click does that too? Tried fresh unzip?
Warning: When making decisions, I try to collect as much data as possible before actually deciding. I try to abstract away and see the principles behind real world events and people's opinions. I try to generalize them and turn into something clear and reusable. I hate depending on unpredictable and having to make lottery guesses. Any problem can be solved by systems thinking and acting.
Yes all this was from fresh unzip.
Ah ok, the problem is with default TAStudio window size, which on my laptop looks like this:
When I try to make a marker in this state the crash happens.
When I expand the columns to look normal I can make markers without issue:
I guess it's trying to make a scroll bar in the 'marker' window and failing because it doesn't fit in the default space.
Joined: 4/17/2010
Posts: 11475
Location: Lake Chargoggagoggmanchauggagoggchaubunagungamaugg
Spikestuff reported the same bug on windows 8.1. I dunno what causes that. You might want to ask zeromus, and probably let him teamview you.
Warning: When making decisions, I try to collect as much data as possible before actually deciding. I try to abstract away and see the principles behind real world events and people's opinions. I try to generalize them and turn into something clear and reusable. I hate depending on unpredictable and having to make lottery guesses. Any problem can be solved by systems thinking and acting.
Oh it turns out I actually ran into some similar issues with NesHawk's tile viewer a while ago and then forgot. The window deisgner seems to make some inconsistencies sometimes.
In this case the 'Markers' and 'Branches' boxes have no minimum size and somehow get corrupted by whatever magic windows is doing to create the window.
I set a minimum size to 50x50 and the error went away completely, and the window now draws correctly after a fresh unzip.
I can commit it if you are happy with that feos.
Joined: 4/17/2010
Posts: 11475
Location: Lake Chargoggagoggmanchauggagoggchaubunagungamaugg
Sounds good to me.
Warning: When making decisions, I try to collect as much data as possible before actually deciding. I try to abstract away and see the principles behind real world events and people's opinions. I try to generalize them and turn into something clear and reusable. I hate depending on unpredictable and having to make lottery guesses. Any problem can be solved by systems thinking and acting.
I'm getting an immediate unhandled exception when opening TAStudio on the latest interim build, but not on 1.11.9.1. TAStudio still works, but without markers or a scrollbar on the piano roll.
System.NullReferenceException: Object reference not set to an instance of an object.
at BizHawk.Client.EmuHawk.MarkerControl.MarkerView_QueryItemBkColor(Int32 index, RollColumn column, Color& color)
at BizHawk.Client.EmuHawk.InputRoll.DoBackGroundCallback(PaintEventArgs e, List`1 visibleColumns)
at BizHawk.Client.EmuHawk.InputRoll.DrawBg(PaintEventArgs e, List`1 visibleColumns)
at BizHawk.Client.EmuHawk.InputRoll.OnPaint(PaintEventArgs e)
at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer)
at System.Windows.Forms.Control.WmPaint(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
Joined: 4/17/2010
Posts: 11475
Location: Lake Chargoggagoggmanchauggagoggchaubunagungamaugg
nrg_zam wrote:
I'm getting an immediate unhandled exception when opening TAStudio on the latest interim build, but not on 1.11.9.1. TAStudio still works, but without markers or a scrollbar on the piano roll.
Everything work for me in both.
Warning: When making decisions, I try to collect as much data as possible before actually deciding. I try to abstract away and see the principles behind real world events and people's opinions. I try to generalize them and turn into something clear and reusable. I hate depending on unpredictable and having to make lottery guesses. Any problem can be solved by systems thinking and acting.
On the latest version, 1.11.9.1, I accidentally clicked the spot next to player 1 in TAStudios for gbc:
Spot in the black outline:
************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at BizHawk.Client.EmuHawk.TAStudio.TasView_MouseDoubleClick(Object sender, MouseEventArgs e)
at System.Windows.Forms.Control.OnMouseDoubleClick(MouseEventArgs e)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
I'm getting an immediate unhandled exception when opening TAStudio on the latest interim build, but not on 1.11.9.1. TAStudio still works, but without markers or a scrollbar on the piano roll.
System.NullReferenceException: Object reference not set to an instance of an object.
at BizHawk.Client.EmuHawk.MarkerControl.MarkerView_QueryItemBkColor(Int32 index, RollColumn column, Color& color)
at BizHawk.Client.EmuHawk.InputRoll.DoBackGroundCallback(PaintEventArgs e, List`1 visibleColumns)
at BizHawk.Client.EmuHawk.InputRoll.DrawBg(PaintEventArgs e, List`1 visibleColumns)
at BizHawk.Client.EmuHawk.InputRoll.OnPaint(PaintEventArgs e)
at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer)
at System.Windows.Forms.Control.WmPaint(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
Hi,
So I had this same bug when I tried to use TAStudio.
I'm not sure how this could have worked for feos since it looks like the code is taking an instance of Emulator before one exists to call Frame from?
I put in a check to make sure it exists and defaults to zero otherwise and now markers are back agian.
I must not be understanding something about how everything works together since this seemed like a pretty serious exception that everyone would have gotten, but hopefully it works now for you too, so maybe give it a try.
Joined: 4/17/2010
Posts: 11475
Location: Lake Chargoggagoggmanchauggagoggchaubunagungamaugg
This is thanks to Windows working so amazingly compatible between versions. Same story as with markers/branches/inputroll separator control.
Warning: When making decisions, I try to collect as much data as possible before actually deciding. I try to abstract away and see the principles behind real world events and people's opinions. I try to generalize them and turn into something clear and reusable. I hate depending on unpredictable and having to make lottery guesses. Any problem can be solved by systems thinking and acting.
Hi,
So I had this same bug when I tried to use TAStudio.
I'm not sure how this could have worked for feos since it looks like the code is taking an instance of Emulator before one exists to call Frame from?
I put in a check to make sure it exists and defaults to zero otherwise and now markers are back agian.
I must not be understanding something about how everything works together since this seemed like a pretty serious exception that everyone would have gotten, but hopefully it works now for you too, so maybe give it a try.
Nice, that did the trick, thanks.
Edit: Actually, after playing with it a bit, I'm still missing the scrollbar on the inputs, and also missing the branch/marker buttons. ex. http://i.imgur.com/badPf0L.png (1.11.9.1 vs interim build)
I don't understand. Tell me in words all you can. And if you can reproduce the bug you're having, tell me the steps. Use your native language if you wish.
Also, for advancing/rewinding, you can use mouse wheel while holding down the right mouse button.
Warning: When making decisions, I try to collect as much data as possible before actually deciding. I try to abstract away and see the principles behind real world events and people's opinions. I try to generalize them and turn into something clear and reusable. I hate depending on unpredictable and having to make lottery guesses. Any problem can be solved by systems thinking and acting.
Joined: 7/25/2015
Posts: 123
Location: Republic of China
feos wrote:
I don't understand. Tell me in words all you can. And if you can reproduce the bug you're having, tell me the steps. Use your native language if you wish.
Also, for advancing/rewinding, you can use mouse wheel while holding down the right mouse button.
Thank you and sorry about my English.
I mean movie will desync when use TAStudio. Look this, I didn't edit it but quick put and slowed down will be two kinds of results, like this pictures from this video. (in frame 56850 green change red).
The problem will happen more than once, To frame behind can't even use came in to fix it.
(My native language Chinese describe：这个视频中，我用TAStudio播放做好的电影，在没更改按键的情况下，快放和慢放会出现不同的效果，也就是不同步。这个视频里的56850讯框只是一个例子，制作后面的40000多讯框我基本都是用减速的方法修正的。虽然56000讯框之后可以通过这种慢放的方法来修正，但是到98000讯框之后就不行了。用TAStudio做完之后导出bk2文件再直接用模拟器播放，到后面结果完全不同，所以我期待解决方法，谢谢。)
Working on:
[NES] Downtown Special - Kunio-kun no Jidaigeki Dayo Zenin Shuugou! (J) ''2 players 100%''
Plan:
[SNES] Kenyuu Densetsu Yaiba (Japan)
_________________
Ｍｙ Ｅｎｇｌｉｓｈ ｉｓ ｐｏｕｒ．
Joined: 4/17/2010
Posts: 11475
Location: Lake Chargoggagoggmanchauggagoggchaubunagungamaugg
Desyncs are usually not the fault of tastudio, but of the core. If you save the regular states at the same frames where you do navigation in tastudio, and change the movie by recording it without tastudio, you might get the same desync in a regular movie. Can you try?
Also, are you tasing with Force Determinism SNES option on?
Warning: When making decisions, I try to collect as much data as possible before actually deciding. I try to abstract away and see the principles behind real world events and people's opinions. I try to generalize them and turn into something clear and reusable. I hate depending on unpredictable and having to make lottery guesses. Any problem can be solved by systems thinking and acting.
Joined: 11/13/2006
Posts: 2822
Location: Northern California
feos wrote:
Desyncs are usually not the fault of tastudio, but of the core.
If it helps, I've gotten a few desyncs across multiple cores (it's happened on Genesis, NES, and SNES so far), and as far as I can tell it's specific to TAStudio and how it handles greenzone. I don't have a proper example, sadly, but I can try to describe it.
I'll do a section and jump back to where I started, play everything through and it works just fine, but if I replay the movie from the beginning (or anywhere outside the original greenzone) it desyncs. Going back to the original greenzone will load in the "correct" version and it will play normally.
It's rare and inconsistent (it only happened maybe 3 times across all of working on Gunstar Heroes and maybe once per movie before that, if at all), I don't know what causes it to happen, and I've only really dealt with it by watching the run from the beginning after each TASing session in order to make sure everything syncs, but it's happened across so many cores that I'm almost positive it has to do with TAStudio.
TASvideos Admin and acting Senior Judge 💙 Currently unable to dedicate a lot of time to the site, taking care of family.
Now infrequently posting on BlueskywarmCabin wrote:
You shouldn't need a degree in computer science to get into this hobby.
Joined: 7/25/2015
Posts: 123
Location: Republic of China
feos wrote:
Desyncs are usually not the fault of tastudio, but of the core. If you save the regular states at the same frames where you do navigation in tastudio, and change the movie by recording it without tastudio, you might get the same desync in a regular movie. Can you try?
Also, are you tasing with Force Determinism SNES option on?
Thank you, maybe that's due to core. I will try as what you said. But I don't think the situation is optimistic. And I tas with Force Determinism SNES option on.
Samsara wrote:
If it helps, …… but it's happened across so many cores that I'm almost positive it has to do with TAStudio.
Yes, is this kind of situation, I save many Markers in early. In this game, during 56000 frame between 98000 frame, I use this way to do, and out of bk2 to replay movie, if it syncs, I will go on. But after 98000, this method doesn't work.
Working on:
[NES] Downtown Special - Kunio-kun no Jidaigeki Dayo Zenin Shuugou! (J) ''2 players 100%''
Plan:
[SNES] Kenyuu Densetsu Yaiba (Japan)
_________________
Ｍｙ Ｅｎｇｌｉｓｈ ｉｓ ｐｏｕｒ．
Joined: 4/17/2010
Posts: 11475
Location: Lake Chargoggagoggmanchauggagoggchaubunagungamaugg
Samsara wrote:
feos wrote:
Desyncs are usually not the fault of tastudio, but of the core.
If it helps, I've gotten a few desyncs across multiple cores (it's happened on Genesis, NES, and SNES so far), and as far as I can tell it's specific to TAStudio and how it handles greenzone. I don't have a proper example, sadly, but I can try to describe it.
I'll do a section and jump back to where I started, play everything through and it works just fine, but if I replay the movie from the beginning (or anywhere outside the original greenzone) it desyncs. Going back to the original greenzone will load in the "correct" version and it will play normally.
It's rare and inconsistent (it only happened maybe 3 times across all of working on Gunstar Heroes and maybe once per movie before that, if at all), I don't know what causes it to happen, and I've only really dealt with it by watching the run from the beginning after each TASing session in order to make sure everything syncs, but it's happened across so many cores that I'm almost positive it has to do with TAStudio.
You might be surprised, but my reason is still valid. Especially with Genesis, where I had the same issue you're describing 1.5 years ago, when it would generate random button presses when I load states. I fixed that by adding more gamepad variables to the savestate, so it was clearly a bug in the core. Then, other people experienced other desyncs with GPGX (the core that's been ported for Genesis).
I've seen savestate bugs in QuickNES as well, while rewinding a movie of SMB.
And bsnes core is also known for being unstable and impossible to properly fix, that's why bizhawk has to make a savestate of every frame, which is exactly what Force Determinism is.
The reason I'm so sure is because TAStudio literally only uses the savestates the cores generate, and when you unpause or scroll the playback cursor down, no states are loaded, it's just frame advance, which yields proper results just like the movie would do, but if you try regular savestates on the same frames and load them in the same situation you're jumping from in tastudio, it will presumably desync exactly the same way, since it's similar savestate manipulation.
Bottomline: Nag core guys to fix these bugs. I used an imaginary code tracer to find my GPGX bug, but some experience is required to understand trace logs and come up with solutions.
Warning: When making decisions, I try to collect as much data as possible before actually deciding. I try to abstract away and see the principles behind real world events and people's opinions. I try to generalize them and turn into something clear and reusable. I hate depending on unpredictable and having to make lottery guesses. Any problem can be solved by systems thinking and acting.
In 1.11.9.1 TAStudio has a bug that removes input when Recording Mode is OFF. It's supposed to only happen when it's set to ON. Even worse, it removes recent input before the current frame.
EDIT: It was because I had rewind settings turned on. Silly me.
In the latest interim build:
1. Open a game
2. Open a tasproj file using the "File>Movie>Recent" dialogue
3. Don't frame advance; it should be at frame 0/whatever
4. Open up TAStudios
See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.
************** Exception Text **************
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource)
at BizHawk.Client.EmuHawk.InputRoll.DoBackGroundCallback(PaintEventArgs e, List`1 visibleColumns)
at BizHawk.Client.EmuHawk.InputRoll.DrawBg(PaintEventArgs e, List`1 visibleColumns)
at BizHawk.Client.EmuHawk.InputRoll.OnPaint(PaintEventArgs e)
at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer)
at System.Windows.Forms.Control.WmPaint(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
http://i.imgur.com/7Blrfpu.png
It then gives the errors shown.
Also completely unrelated, but whenever I open TAStudios, my RAM watch window clears out. Can this please be changed so that it doesn't do that?
Edit: Why were the buttons in TAStudio regarding the branches and markers removed? Similarly with the scrollbar.
Joined: 4/17/2010
Posts: 11475
Location: Lake Chargoggagoggmanchauggagoggchaubunagungamaugg
jlun2 wrote:
In the latest interim build:
1. Open a game
2. Open a tasproj file using the "File>Movie>Recent" dialogue
3. Don't frame advance; it should be at frame 0/whatever
4. Open up TAStudios
Fixed.
jlun2 wrote:
Why were the buttons in TAStudio regarding the branches and markers removed? Similarly with the scrollbar.
Poke Alyosha. I dunno if it's Win10 having wrong DPI or font size by default, but Alyosha's Designer also shrunk the Playback buttons.
Warning: When making decisions, I try to collect as much data as possible before actually deciding. I try to abstract away and see the principles behind real world events and people's opinions. I try to generalize them and turn into something clear and reusable. I hate depending on unpredictable and having to make lottery guesses. Any problem can be solved by systems thinking and acting.
Everything works and looks correct to me.
What OS are you working with jlun2? You and nrg_zam seem to be having the same issue.
@feos: do you think my commit that fixed the original issue i was having should be reverted? It seems like it might be cause of problems here. Maybe then i can find a more surgical fix for windows 10, since I'll at least be able to see the problem, without messing things up for other users.
Joined: 4/17/2010
Posts: 11475
Location: Lake Chargoggagoggmanchauggagoggchaubunagungamaugg
Alyosha wrote:
@feos: do you think my commit that fixed the original issue i was having should be reverted?
At least for now I guess. All scrollbars are also missing for me.
Warning: When making decisions, I try to collect as much data as possible before actually deciding. I try to abstract away and see the principles behind real world events and people's opinions. I try to generalize them and turn into something clear and reusable. I hate depending on unpredictable and having to make lottery guesses. Any problem can be solved by systems thinking and acting.
Everything works and looks correct to me.
What OS are you working with jlun2? You and nrg_zam seem to be having the same issue.
@feos: do you think my commit that fixed the original issue i was having should be reverted? It seems like it might be cause of problems here. Maybe then i can find a more surgical fix for windows 10, since I'll at least be able to see the problem, without messing things up for other users.
http://imgur.com/p9n4kIR
Edition: Windows 10 Home
Version 1607
OS Build: 14393.576
How about you?
When I try to make a marker in this state the crash happens.
When I expand the columns to look normal I can make markers without issue:
I guess it's trying to make a scroll bar in the 'marker' window and failing because it doesn't fit in the default space.
The problem will happen more than once, To frame behind can't even use came in to fix it.
(My native language Chinese describe：这个视频中，我用TAStudio播放做好的电影，在没更改按键的情况下，快放和慢放会出现不同的效果，也就是不同步。这个视频里的56850讯框只是一个例子，制作后面的40000多讯框我基本都是用减速的方法修正的。虽然56000讯框之后可以通过这种慢放的方法来修正，但是到98000讯框之后就不行了。用TAStudio做完之后导出bk2文件再直接用模拟器播放，到后面结果完全不同，所以我期待解决方法，谢谢。)
