Topic by WST

Posted: 7/27/2012 1:48 PM

Quote

WST

She/Her

Active player (442)

Joined: 10/6/2011
Posts: 1690
Location: RU · ID · AM

Why not to set display_errors to be off? It’s the production site, I beleive it’s normal solution in this case. Also, just for your info, in my code I always filter all request variables and allow to be arrays only those of them which are supposed to be arrays.

S3&A [Amy amy%] improvement (with Evil_3D & kaan55) — currently in SPZ2 my TAS channel · If I ever come into your dream, I’ll be riding an eggship :)

Posted: 8/5/2012 9:30 PM

Quote

NitroGenesis

He/Him

Editor, Experienced player (551)

Joined: 12/24/2009
Posts: 1873

If you rate a movie without giving a rating to one of the categories, it lowers your average score. How come? I was going to rate movies only on entertainment, but it seems that I'm bringing down movie ratings unfairly.

YoungJ1997lol wrote:

Normally i would say Yes, but thennI thought "its not the same hack" so ill stick with meh.

Posted: 8/5/2012 9:33 PM

Quote

Ilari

Emulator Coder, Skilled player (1141)

Joined: 5/1/2010
Posts: 1217

NitroGenesis wrote:

If you rate a movie without giving a rating to one of the categories, it lowers your average score.

Can you give some example movie where you think that is happening?

Posted: 8/5/2012 9:34 PM

Quote

NitroGenesis

He/Him

Editor, Experienced player (551)

Joined: 12/24/2009
Posts: 1873

I'm sure Mr AKheon won't mind if I use his rating page as an example. http://tasvideos.org/rating.exe/users/AKheon/

YoungJ1997lol wrote:

Normally i would say Yes, but thennI thought "its not the same hack" so ill stick with meh.

Posted: 8/5/2012 10:00 PM

Quote

Ilari

Emulator Coder, Skilled player (1141)

Joined: 5/1/2010
Posts: 1217

NitroGenesis wrote:

I'm sure Mr AKheon won't mind if I use his rating page as an example.

Fixed. It erroneously regarded missing ratings as zero ratings when computing the average for that user / movie. Edit: Bug I noted in user movies (causes need to be determined): The World of Goo submission file can't be uploaded. It seems that the POST variables are not received for some reason??? Because the file is too large? Edit2: Worked around that by allowing uploads of movies inside .zip. Won't fix the root cause (would need streaming upload code) but allows uploading stuff that previously couldn't be uploaded.

Posted: 8/13/2012 5:04 PM

Quote

Tub

Joined: 6/25/2005
Posts: 1377

On the main page news module, can we please get proper links behind the headlines? I tried middle-clicking the headline to open the post in a new tab, but since it's not actually a link, it didn't work. change <h3 style="cursor:pointer;" onmouseover="this.style.textDecoration='underline';" onmouseout="this.style.textDecoration='none';" onclick="document.getElementById('post_323367').style.display='';">Official WIP movie storage</h3> to <h3><a href="http://tasvideos.org/forum/viewtopic.php?p=323367#323367" onclick="document.getElementById('post_323367').style.display='';return false;">Official WIP movie storage</a></h3> and left-clicking should work as before, while middle-clicking should start working as expected.

m00

Posted: 8/13/2012 6:25 PM

Quote

Nach

Emulator Coder

Joined: 3/9/2004
Posts: 4588
Location: In his lab studying psychology to find new ways to torture TASers and forumers

Tub wrote:

On the main page news module, can we please get proper links behind the headlines? I tried middle-clicking the headline to open the post in a new tab, but since it's not actually a link, it didn't work.

I absolutely hate it when sites do that, especially using an a tag which doesn't actually go anywhere, and you get a new tab with JavaScript in it. I've gone around fixing such silliness in different parts of the site. I fixed it here too, and it should be live on the site soon. Thanks for the report.

Warning: Opinions expressed by Nach or others in this post do not necessarily reflect the views, opinions, or position of Nach himself on the matter(s) being discussed therein.

Posted: 8/13/2012 10:07 PM

Quote

Tub

Joined: 6/25/2005
Posts: 1377

Thank you. Though the links now look differently (blue instead of black); if that wasn't intended, some css rules are required. .newsfloat h3 a { color: black; text-decoration: none; } .newsfloat h3 a:hover { text-decoration: underline; } and the click-handler could be changed into var s=document.getElementById('post_323367').style;s.display = s.display=='none'?'':'none'; or something so you can close the news again. But meh, minor nitpicks. Thanks!

m00

Posted: 8/14/2012 12:40 PM

Quote

Ilari

Emulator Coder, Skilled player (1141)

Joined: 5/1/2010
Posts: 1217

The following fixes to user movie upload have been done (following report about problems with it on IRC)

Some blurb about filename needing to have suitable extension.
Automatically guess the filename (using either the filename of the uploaded file or the filename inside the .zip) if the input is left blank.
Don't do utterly crazy things if the uploaded .zip contains multiple files.
Hopefully more informative error message on bad extension.

Posted: 8/19/2012 5:06 PM

Quote

hegyak

Editor

Joined: 3/31/2010
Posts: 1466
Location: Not playing Puyo Tetris

I don't know how, but I made a bug using the URL tag. Moderators/admins, please edit the next post to see the odd URLs.

When TAS does Quake 1, SDA will declare war. The Prince doth arrive he doth please.

Posted: 8/19/2012 5:06 PM

Quote

hegyak

Editor

Joined: 3/31/2010
Posts: 1466
Location: Not playing Puyo Tetris

http://puyonexus.net/wiki/Scoring http://puyonexus.net/wiki/Non-Stop_Fever http://puyonexus.net/wiki/Puyo_Puyo!_15th_Anniversary

When TAS does Quake 1, SDA will declare war. The Prince doth arrive he doth please.

Posted: 8/19/2012 5:20 PM

Quote

Ilari

Emulator Coder, Skilled player (1141)

Joined: 5/1/2010
Posts: 1217

Looks like it is the '!' in one of the URL paths that breaks stuff (rendering the entire post invisible). Escaping it as %21 seems to work (even if URL syntax doesn't seem to require it). Also, the following characters in URLs break the post: *, ', ( and ). The escape codes are %2a, %27, %28 and %29 (in order).

Posted: 8/19/2012 5:51 PM

Quote

Nach

Emulator Coder

Joined: 3/9/2004
Posts: 4588
Location: In his lab studying psychology to find new ways to torture TASers and forumers

I'll see what I can do. Thanks for the report.

Warning: Opinions expressed by Nach or others in this post do not necessarily reflect the views, opinions, or position of Nach himself on the matter(s) being discussed therein.

Posted: 8/19/2012 10:09 PM

Quote

scrimpeh

Editor, Skilled player (1404)

Joined: 3/31/2010
Posts: 2086

Unchecking "Attach Avatar" doesn't work. You guys might want to fix that.

Posted: 8/20/2012 3:39 AM

Quote

CoolKirby

Editor, Experienced player (608)

Joined: 11/8/2010
Posts: 4012

A minor bug: This post looks normal in the thread I posted it in, but the hyperlink does not end on the search page for posts by CoolKirby. This might cause other links in a post to lose their link locations, at least on the search page. The HTML of the search page just moves the </a> at the end of "HxD" to the end of the post. It seems like it should be easy to fix.

Posted: 9/8/2012 12:40 AM

Quote

RachelB

She/Her

Player (127)

Joined: 12/3/2011
Posts: 1579

A link directly following bb code without a space isn't automatically parsed. example:http://tasvideos.org/forum/viewtopic.php?t=8253&start=220

Posted: 9/13/2012 7:00 AM

Post subject: Publication HTTPS link woes

Quote

Ilari

Emulator Coder, Skilled player (1141)

Joined: 5/1/2010
Posts: 1217

1) Trying to add https mirror link results in error message about having multiple mirrors from the same site. 1-a) This occurs even if there aren't any mirrors already. 1-b) This occurs even for users that have privilege to override the multiple mirror check. 2) Trying to replace mirror with https mirror link results in mirror being deleted with no replacement. 2-a) Even if this is the last mirror and user doesn't have privileges to bring mirror count to zero. 3) One can publish a movie with https:// mirror link entered... Resulting a publication with no mirrors. This was noticed as apparently recently archive.org started offering https links (the collection pages on https://archive.org/details/ links to https URLs for files). * Resulting in such URLs to be put as mirror URLs and torrent webseed URLs. * HTTPS torrent webseed URLs have their own problems (but that's not a site bug). How to fix this (there are multiple different ways)? 1) Allow HTTPS links, treating http://foo.example/ and https://foo.example/ as different. 2) Allow HTTPS links, treating http://foo.example/ and https://foo.example/ as the same. 3) Add explicit check against adding non-HTTP links, so those can be rejected early.

Posted: 11/10/2012 6:44 PM

Quote

RachelB

She/Her

Player (127)

Joined: 12/3/2011
Posts: 1579

http://i.imgur.com/bqwL0.png I don't think that should be tiling.

Posted: 11/10/2012 11:39 PM

Quote

Ilari

Emulator Coder, Skilled player (1141)

Joined: 5/1/2010
Posts: 1217

rog wrote:

http://i.imgur.com/bqwL0.png I don't think that should be tiling.

Unfortunately, fixing it isn't trivial: - If one disables tiling, it looks bad. - Extending the image isn't that simple either, because the background is not quite a vertical gradient (trying to use copy'n'paste to extend it causes seams).

Posted: 11/11/2012 12:16 AM

Quote

RachelB

She/Her

Player (127)

Joined: 12/3/2011
Posts: 1579

I guess i'll just adblock it then. Do let me know if it's ever fixed.

Posted: 11/11/2012 9:41 PM

Quote

WST

She/Her

Active player (442)

Joined: 10/6/2011
Posts: 1690
Location: RU · ID · AM

For some reason my download speed from archive.org is 3–4 times less than from european servers. It’s actually not a website’s problem, it’s a problem of international link between Russia and USA, I think… Link to video This is not a bug report in any way, just an observation, didn’t know where to post it… P.S.: yes, I prefer BitTorrent, again, this is just an observation.

S3&A [Amy amy%] improvement (with Evil_3D & kaan55) — currently in SPZ2 my TAS channel · If I ever come into your dream, I’ll be riding an eggship :)

Posted: 11/11/2012 11:11 PM

Quote

partyboy1a

Player (136)

Joined: 9/18/2007
Posts: 389

The links to "obsoleted" movies on game view pages don't work, and the links to the actual submission don't work too. Example: 1p warpless movie: Link to obsoleted movie: It should be http://tasvideos.org/284M.html. It actually is http://tasvideos.org/Game/284M.html. Link to submission: It should be http://tasvideos.org/604S.html. It actually is http://tasvideos.org/Game/604S.html same for: link to publication, link to "rate this movie" wow, that was a fast fix.

Posted: 11/11/2012 11:35 PM

Quote

Ilari

Emulator Coder, Skilled player (1141)

Joined: 5/1/2010
Posts: 1217

partyboy1a wrote:

~~The links to "obsoleted" movies on game view pages don't work, and the links to the actual submission don't work too.~~ wow, that was a fast fix.

Oh, nice finding of very subtle bug. It is not fixed yet. And it is not game page specific problem. I just reproduced the problem on a subpage of my homepage. Even the links to other wiki pages break. I know what is going on: The movie module is aggressively cached[1], but involves relative links, which usually break if the "depth" changes (especially if it increases). Normally movie module only appears on "depth 0" (http://tasvideos.org/foo.html), but the game pages put it on "depth 1" (http://tasvideos.org/foo/bar.html). But the game pages aren't the only way "depth 1" (or even greater depths) can appear: You get that too if you put it on a subpage. Edit: Did a slightly nasty hack to work around the problem... [1] The entire HTML of the resulting box is cached.

Posted: 11/15/2012 9:57 AM

Post subject: Duplicated entries in Movie Statistics

Quote

klmz

Editor, Emulator Coder, Expert player (2105)

Joined: 5/22/2007
Posts: 1134
Location: Glitchvania

Movie Statistic: Lowest number of ratings I saw duplicated entries of 2109M, 2079M and 2031M.

<klmz> it reminds me of that people used to keep quoting adelikat's IRC statements in the old good days <adelikat> no doubt <adelikat> klmz, they still do

Posted: 11/15/2012 11:11 AM

Post subject: Re: Duplicated entries in Movie Statistics

Quote

Warp

Banned User, Former player

Joined: 3/10/2004
Posts: 7698
Location: Finland

klmz wrote:

Movie Statistic: Lowest number of ratings I saw duplicated entries of 2109M, 2079M and 2031M.

I think the code gets duplicate entries from the database in certain situations, but I don't remember the details. (The fix would be to merge duplicates in said code.)

Locked